I am not an owner of anything in this CL, but I am happy to offer my
thoughts
...
https://codereview.chromium.org/1308693014/diff/1/src/interpreter/bytecode-generator.cc
File src/interpreter/bytecode-generator.cc (right):
https://codereview.chromium.org/1308693014/diff/1/src/interpreter/bytecode-generator.cc#newcode50
src/interpreter/bytecode-generator.cc:50: if
(!builder_.HasExplicitReturn()) {
This looks dangerous. Depending on how control flow is modeled there
could very well be a case where the last instruction in the byte-code
stream is a return statement, but it is not guaranteed post-dominate all
executions paths. Consider the following ...
function f(a) {
if (a) { return 23; }
}
https://codereview.chromium.org/1308693014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
