LGTM with nits.
Doing the !IS_UNDEFINED check at callsites is rather sad. It would be nice
if
$toInteger took care of that without deopting; but changing that might be
more
involved as it might have unexpected side effects.
https://codereview.chromium.org/1324353002/diff/40001/src/string.js
File src/string.js (right):
https://codereview.chromium.org/1324353002/diff/40001/src/string.js#newcode1002
src/string.js:1002: return false;
nit: {} for multi-line ifs
https://codereview.chromium.org/1324353002/diff/40001/src/string.js#newcode1040
src/string.js:1040: return false;
nit: {} for multi-line ifs
https://codereview.chromium.org/1324353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
