Reviewers: Jarin,
Message:
Hey Jaro, Camillo,
This is the initial part of the %_CallFunction fixification.
Please take a look.
Thanks,
Benedikt
Description:
[runtime] Replace many buggy uses of %_CallFunction with %_Call.
The semantics of the %_CallFunction intrinsic seem to be very unclear,
which resulted in a lot of bugs. Especially the combination with
%IsSloppyModeFunction is always a bug, because the receiver would be
wrapped in the wrong context. So the %IsSloppyModeFunction helper is
gone now, and many of the buggy uses of %_CallFunction are also
eliminated.
If you ever need to call something with a different receiver, then
%_Call is your friend now. It does what you want and implements the
call sequence fully (and correct).
BUG=v8:4413
LOG=n
Please review this at https://codereview.chromium.org/1325573004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+310, -182 lines):
M src/arm/interface-descriptors-arm.cc
M src/arm64/interface-descriptors-arm64.cc
M src/array.js
M src/collection.js
M src/compiler/linkage.cc
M src/full-codegen/arm/full-codegen-arm.cc
M src/full-codegen/arm64/full-codegen-arm64.cc
M src/full-codegen/full-codegen.h
M src/full-codegen/ia32/full-codegen-ia32.cc
M src/full-codegen/mips/full-codegen-mips.cc
M src/full-codegen/mips64/full-codegen-mips64.cc
M src/full-codegen/x64/full-codegen-x64.cc
M src/harmony-array.js
M src/harmony-typedarray.js
M src/hydrogen.h
M src/hydrogen.cc
M src/ia32/interface-descriptors-ia32.cc
M src/interface-descriptors.h
M src/interface-descriptors.cc
M src/json.js
M src/macros.py
M src/mips/interface-descriptors-mips.cc
M src/mips64/interface-descriptors-mips64.cc
M src/object-observe.js
M src/promise.js
M src/runtime.js
M src/runtime/runtime.h
M src/runtime/runtime-function.cc
M src/string.js
M src/typedarray.js
M src/weak-collection.js
M src/x64/interface-descriptors-x64.cc
M test/mjsunit/debug-liveedit-check-stack.js
M test/mjsunit/harmony/proxies-function.js
M test/mjsunit/strong/function-arity.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
