Thank you!
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.cc
File src/heap/incremental-marking-job.cc (right):
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.cc#newcode27
src/heap/incremental-marking-job.cc:27:
made_progress_since_last_delayed_task_ = false;
On 2015/09/08 10:16:26, Michael Lippautz wrote:
This should be true, I guess. Otherwise the DelayedTask is forced to
do work all
the time (?)
Also, maybe call it NotifyIdleTaskProgress() as it only indicates
progress in
idle tasks and not overall (including delayed) tasks.
Good catch! This slipped through during last minute refactoring.
Fixed and renamed.
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.cc#newcode45
src/heap/incremental-marking-job.cc:45: const int kDelayInSeconds = 5;
On 2015/09/08 10:16:26, Michael Lippautz wrote:
nit: Can we make this a constant in IncrementalMarkingJob?
Done.
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.h
File src/heap/incremental-marking-job.h (right):
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.h#newcode23
src/heap/incremental-marking-job.h:23: // which can happen for
background tab in Chrome.
On 2015/09/08 10:16:26, Michael Lippautz wrote:
nit: s/tab/tabs/
Done.
https://codereview.chromium.org/1265423002/diff/140001/src/heap/incremental-marking-job.h#newcode62
src/heap/incremental-marking-job.h:62: void Start(Heap* heap) {
On 2015/09/08 10:16:26, Michael Lippautz wrote:
IncrementalMarkingJob is reused as far as I see. We should reset the
member
fields on start, as we might end up with
made_progress_since_last_delayed_task_
= true from the last round. (After fixing NotifyProgress())
Added a comment explaining why we shouldn't reset the fields.
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
