https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descriptors-arm.cc
File src/arm/interface-descriptors-arm.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/arm/interface-descriptors-arm.cc#newcode196
src/arm/interface-descriptors-arm.cc:196: CallInterfaceDescriptorData*
data) {
On 2015/09/08 11:19:13, cbruni wrote:
// r1: target
// r0: number of arguments

Done.

https://codereview.chromium.org/1325573004/diff/20001/src/ia32/interface-descriptors-ia32.cc
File src/ia32/interface-descriptors-ia32.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/ia32/interface-descriptors-ia32.cc#newcode202
src/ia32/interface-descriptors-ia32.cc:202: CallInterfaceDescriptorData*
data) {
On 2015/09/08 11:19:13, cbruni wrote:
// edi: target
// eax: number of arguments

Done.

https://codereview.chromium.org/1325573004/diff/20001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/1325573004/diff/20001/src/object-observe.js#newcode604
src/object-observe.js:604: changeRecord = %_Call(changeFn, UNDEFINED);
On 2015/09/08 11:19:13, cbruni wrote:
changeFn() ?

Done.

https://codereview.chromium.org/1325573004/diff/20001/src/x64/interface-descriptors-x64.cc
File src/x64/interface-descriptors-x64.cc (right):

https://codereview.chromium.org/1325573004/diff/20001/src/x64/interface-descriptors-x64.cc#newcode195
src/x64/interface-descriptors-x64.cc:195: CallInterfaceDescriptorData*
data) {
On 2015/09/08 11:19:13, cbruni wrote:
// rdi: target
// rax: number of arguments

Done.

https://codereview.chromium.org/1325573004/diff/40001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/1325573004/diff/40001/src/array.js#newcode925
src/array.js:925: return comparefn(a[1], b[1]);
Doable, but in a separate CL.

https://codereview.chromium.org/1325573004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to