Reviewers: jochen,
Message:
Please let me know whether the approach is acceptable. I have to admit
defeat on
the GYP front.
Description:
Remove all gyp BUILD rules with multiple outputs.
- Modify js2c to accept --js and --nojs,
- modify mksnapshot to accept --startup_src
(instead of a positional parameter, so that it can be omitted),
- modify v8.gyp to use the above so that no target has multiple
output dependencies, and
- update GN to use the switches above.
(I have not succeeded in fixing the GYP->make translator to properly map
multi-output rules, so that they work as expected in all edge cases.
This CL signals defeat on that front, and instead I rewrite the GYP
file to avoid that situation in the first place.)
[email protected]
BUG=v8:4382
LOG=N
Please review this at https://codereview.chromium.org/1310273009/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+107, -64 lines):
M BUILD.gn
M src/flag-definitions.h
M src/snapshot/mksnapshot.cc
M tools/gyp/v8.gyp
M tools/js2c.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
