Reviewers: danno, Michael Starzinger, paul.l..., akos.palfi.imgtec,
Description:
MIPS: Fix 'Optimize simulator.'
For simulator optimization we modified Instruction::InstructionType()
function
so a simpler but less complete InstructionType() function used by default.
This
fix enables the full InstructionType checking to properly decode a
dd-constant
label as unsupported opcode, rather than aborting.
BUG=
Please review this at https://codereview.chromium.org/1314673010/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/mips/disasm-mips.cc
Index: src/mips/disasm-mips.cc
diff --git a/src/mips/disasm-mips.cc b/src/mips/disasm-mips.cc
index
6028e90b4410a5a479fe51414ac5be9977b33b37..f24ec436f0064ef6162f4809f68d3c5e619a614a
100644
--- a/src/mips/disasm-mips.cc
+++ b/src/mips/disasm-mips.cc
@@ -1606,7 +1606,7 @@ int Decoder::InstructionDecode(byte* instr_ptr) {
out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_,
"%08x ",
instr->InstructionBits());
- switch (instr->InstructionType()) {
+ switch (instr->InstructionType(Instruction::EXTRA)) {
case Instruction::kRegisterType: {
DecodeTypeRegister(instr);
break;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
