Ah, you can ignore my comment about SLOPPY/STRICT because I see elsewhere
that
you are only handling SLOPPY for now.
Nice tests, again!
LGTM.
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter.cc#newcode256
src/interpreter/interpreter.cc:256:
CodeFactory::StoreICInOptimizedCode(isolate_, SLOPPY, UNINITIALIZED);
Don't you need to pick up SLOPPY or STRICT from elsewhere?
https://codereview.chromium.org/1319833004/diff/1/src/interpreter/interpreter.cc#newcode267
src/interpreter/interpreter.cc:267:
CodeFactory::KeyedStoreICInOptimizedCode(isolate_, SLOPPY,
UNINITIALIZED);
Same here...
https://codereview.chromium.org/1319833004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
