I agree that some refactoring here would be helpful for readability, but
I'm not
sure the switch statement you landed on was it. So I'd suggest going with a
minimal fix and dealing with the refactoring separately.
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/40001/src/preparser.h#newcode2663
src/preparser.h:2663: goto shorthand_property;
Can't you just do without the goto?
} else if ((is_get || is_set) &&
(in_class ||
(peek() != Token::ASSIGN &&
peek() != Token::COMMA &&
peek() != Token::RBRACE)) {
that'll fall through to the next else/if.
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1328083002/diff/80001/src/preparser.h#newcode2641
src/preparser.h:2641: break;
This break makes this whole approach not much easier to read (for me)
than the old version.
https://codereview.chromium.org/1328083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
