On 2015/09/09 00:24:48, caitp wrote:
Thanks for the look. It's not clear this can land soon, but i can keep
working
on it
https://codereview.chromium.org/1308123007/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1308123007/diff/1/test/mjsunit/harmony/destructuring.js#newcode959
test/mjsunit/harmony/destructuring.js:959: assertDoesNotThrow("function
f({x})
{
var x; }; f({});");
On 2015/09/09 00:07:02, adamk wrote:
> So this is no longer an error, but yet
>
> function f({x = undefined}) { var x; }
>
> is an error.
>
> Seems like there's a deeper problem here. I need to tech up my
spec-reading
to
> fully grok IteratorBindingInitialization, but it seems like the
let-binding-ness
> shouldn't have anything to do with the ContainsExpression bit.
That's a known issue. I have two plans to fix it. But, there's a cost: one
requires the implementation of the spec change from July 29th re:
directives
in
functions with non-simple parameters, and the other requires a change to
the
ast
node to track the declaration kind of a variable declaration. So i
thought I'd
keep that as a TODO for now. What do you think? The AST change is just so
the
redeclaration error can be avoided for lexical parameters.
Is the known issue catalogued somewhere (with the proper behavior spelled
out)?
I realize I'm a bit late to the destructuring party, but it's worrying to me
that there are so many bugs in plain sight. Mostly in the sense that it's
unclear at any point what's done and what's still-to-be-done.
https://codereview.chromium.org/1308123007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
