On 2010/02/17 18:09:12, Vitaly wrote:
Ported to other architectures. Please take another look.

Actually, no, wait. I just found a special case in codegen-ia32.cc
(VisitCompareOperation) that already generates (slightly different) inlined code
for typeof(foo) === 'bar'. This means the extra speed up comes only from the
fact that we avoid ToString calls. In other words I think inlining ToString
makes sense, but inlining the type checks doesn't since it's already done in the
compiler. I'll rework the change and remeasure performance.

-- Vitaly


http://codereview.chromium.org/596122

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to