https://codereview.chromium.org/1327033003/diff/20001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1327033003/diff/20001/tools/run_perf.py#newcode651
tools/run_perf.py:651: if profiler_run:
Suggestion: Could you maybe just use the existing extra_flags list? I.e.
make '--prof' a flag that triggers the additional logic below. The
condition here could be rewritten as:
if '--prof' in self.extra_flags:
...
The tool could be started with:
run_perf --extra-flags="--prof --other-flag1 ..."
The check for the d8 executable above in line 459 could be made in a
similar way, e.g.:
extra_flags = extra_flags or []
if self.binary != 'd8' and '--prof' in self.extra_flags:
# Warn about wrong usage.
https://codereview.chromium.org/1327033003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
