Thanks Bruce, and apologies for making work. CL pending. On Mon, Sep 14, 2015 at 6:43 PM, <[email protected]> wrote:
> This mornings 'new warning' report from the /analyzer builder pointed out > some > variable shadowing. Not bugs, but worth mentioning. > > > > https://codereview.chromium.org/1291693004/diff/340001/src/compiler/bytecode-graph-builder.cc > File src/compiler/bytecode-graph-builder.cc (right): > > > https://codereview.chromium.org/1291693004/diff/340001/src/compiler/bytecode-graph-builder.cc#newcode392 > src/compiler/bytecode-graph-builder.cc:392: const Operator* op = > common()->IfSuccess(); > This shadows the 'op' function parameter, which makes the code slightly > more confusing. Consider renaming to avoid shadowing? > > > https://codereview.chromium.org/1291693004/diff/340001/src/compiler/bytecode-graph-builder.cc#newcode418 > src/compiler/bytecode-graph-builder.cc:418: Node* inputs[] = {control, > other}; > This shadows the local 'inputs' variable declared at the top. I'm not > sure whether the types being different makes it more or less confusing. > > Consider renaming to avoid shadowing? > > https://codereview.chromium.org/1291693004/ > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
