lgtm % naming
https://codereview.chromium.org/1332873003/diff/80001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1332873003/diff/80001/src/parser.cc#newcode4967
src/parser.cc:4967: Declare(declaration, DeclarationDescriptor::NORMAL,
true, ok);
On 2015/09/17 17:44:10, Dan Ehrenberg wrote:
On 2015/09/11 at 15:42:56, adamk wrote:
> I'm a little bit confused: why do you use the passed-in scope above,
but the
current scope_ here (since you don't pass the last argument)? Are
|scope| and
|scope_| actually the same here?
It happens to work because this is called when coming back out to the
function
scope, but that's unclear, so I passed scope.
Thanks, this looks better. A later cleanup (not in this CL) should
probably make that argument non-optional and make Declare static, to
avoid other member accesses of scope_creeping in.
https://codereview.chromium.org/1332873003/diff/120001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1332873003/diff/120001/src/ast.h#newcode1276
src/ast.h:1276: class DelegateStatement final : public Statement {
I thought this was going to get renamed? I believe the proposal was
"SloppyBlockFunctionStatement"?
https://codereview.chromium.org/1332873003/diff/120001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1332873003/diff/120001/src/scopes.h#newcode74
src/scopes.h:74: typedef ZoneVector<DelegateStatement*> DelegateVector;
This typedef shouldn't be at toplevel (the name is too general). How
about making it public in SloppyBlockFunctionMap, instead?
https://codereview.chromium.org/1332873003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
