On 2015/10/23 00:24:11, Nico (vacation Fri Oct 23) wrote:
Zombie review comment! Can you expand on the "as discussed" bit a bit? The
BUG=
line is just some generic tracking bug, and the CL description doesn't
really
say what's happening here. I think it was because bool bitfields are
considered
signed and aren't packed tightly with neighboring unsigned bitfields, but
it'd
be good if the commit description or the review had some more detail from
the
author what the intent was :-)
This CL replaced https://codereview.chromium.org/694003002/ which contained
more
background. (You're right, of course, that the justification should have
been
copied over.)
In short: 1-bit bitfields for 2-value enums (like "enum Foo { kBar, kBaz};
Foo
foo_ : 1;") are a correctness issue in VC++.
https://codereview.chromium.org/700963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
