On 2015/10/28 05:03:10, caitp wrote:
On 2015/10/27 23:23:58, adamk wrote:
> https://codereview.chromium.org/1309813007/diff/150001/src/preparser.h
> File src/preparser.h (right):
>
>
https://codereview.chromium.org/1309813007/diff/150001/src/preparser.h#newcode2477
> src/preparser.h:2477: bool old_state_ = PushArrowFormalsState(true);
> On 2015/10/27 23:20:05, caitp wrote:
> > On 2015/10/27 23:04:18, adamk wrote:
> > > Can't you wrap the next few lines in a block and use an RAII object
here
> > instead
> > > of calling these directly?
> >
> > As mentioned, the second version gets rid of all this extra parser
state,
it
> may
> > be a simpler. Which one do you think would be preferred?
>
> That comment makes more sense now that I've read the first approach :)
>
> I prefer passing state via params, as that's consistent with what we
have
> already (e.g., accept_IN). From a quick perusal of your second approach
it
looks
> like that's what it does, but brain too fried for the day (from
> eval-parsing-in-arrow-formal-parameters) to give a detailed review of
patchsets
> 10 or 11.
The last change isn't a clean diff because of the rebase, but it turns
out I
wasn't on the right issue because had to do the 3-way merge, so there's a
clean
version on https://codereview.chromium.org/1411203002
wait, no, that's not a clean diff either, I guess that was the other part of
this. So no luck then =]
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
