Reviewers: jochen, scottmg
CL: https://codereview.chromium.org/1237803003/
Message:
PTAL. Is there some logics in chromium that'll force a full recompile if the
msvs version changes?
https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8
File build/gyp_v8 (right):
https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8#newcode54
build/gyp_v8:54: def GetOutputDirectory():
1:1 c/p from chromium
https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8#newcode106
build/gyp_v8:106: vs2013_runtime_dll_dirs =
vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
1:1 c/p from chromium
https://codereview.chromium.org/1237803003/diff/180001/build/standalone.gypi
File build/standalone.gypi (left):
https://codereview.chromium.org/1237803003/diff/180001/build/standalone.gypi#oldcode209
build/standalone.gypi:209: # goma doesn't support PDB yet, so win_z7=1
or fastbuild=1.
This was an old c/p that was never exercised in v8.
Description:
Use msvs toolchain from depot_tools.
This ports some code from chromium for using the bundled
toolchain.
BUG=chromium:548586
LOG=n
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+330, -6 lines):
M .gitignore
M DEPS
M build/gyp_environment.py
M build/gyp_v8
M build/standalone.gypi
A build/vs_toolchain.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
