On Wed, Nov 11, 2015 at 9:03 AM, Ross McIlroy <[email protected]> wrote:
> Recently we have started running a subset of the mjsunit and test262 tests > in the Ignition interpreter on the V8 test bots. In order to keep the > waterfall green, we are going to start running these tests on the commit > queue (CQ) as well (once https://codereview.chromium.org/1440673002/ > lands). > > Since Ignition doesn't support all JavaScript features yet, you may see CQ > failures on these tests for your own CLs if you add a new mjsunit test or > modify V8 such that existing test runs differently. If you see a failure > for a test in MjsunitIgnition or Test262Ignition, just add a line to the > ignition section of test/mjsunit/mjsunit.status or > test/test262/test262.status to skip the test on ignition, and let me know. > > Please let me know if you have any problems with these tests or the > process of if adding these skips becomes too burdensome. > If the only action when the CQ bots fail is going to be to add lines to the status file, why is this approach more useful than just letting the bot go red on failures (and leave it out of the CQ)? It seems like in either strategy, manual intervention from the Ignition team will be necessary to further-triage the failure, and the plan proposed by Ross is strictly more work. - Adam > > Cheers, > Ross > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
