Looking through that ChangeLog it doesn't look particularly useful (most releases have no log lines, though I suspect many of them do have significant changes).
What if we relaxed the presubmit to allow BUG= lines without LOG= lines? That would solve my main problem, while still letting people add LOG=Y lines if they think it's appropriate. The fact that the presubmit only complains for patches that have a BUG line seems like a perverse incentive to avoid using tracking bugs. On Mon, Jan 11, 2016 at 12:43 AM, Jakob Kummerow <[email protected]> wrote: > Yeah, the ChangeLog is still generated from LOG=y commits: > https://chromium.googlesource.com/v8/v8/+/branch-heads/4.8/ChangeLog > (Note that the master branch's ChangeLog is not updated automatically; > syncing it to the latest branch-head is a manual process that apparently > hasn't been done in half a year.) > > We've discussed getting rid of the ChangeLog repeatedly over the years. > Nobody on our team needs/uses it, however there do seem to be some external > people reading it; or at least that was the conclusion last time this came > up. We could ask on v8-users if anyone would be unhappy if we dropped it, > but that question doesn't necessarily reach everyone who might care, so > it's hard to be sure. > > > On Mon, Jan 11, 2016 at 9:23 AM, 'Michael Hablich' via v8-dev < > [email protected]> wrote: > >> My impression is that LOG=Y should be used for CLs which are notable/ >> should be on a changelog. I think some infra scripts are using this >> information but machenbach@ surely knows more about this. >> >> >> On Fri, Jan 8, 2016 at 8:45 PM Adam Klein <[email protected]> wrote: >> >>> Back in the day, when we were still on SVN and all V8 releases were >>> blobs of merged changes, the LOG=Y served a good purpose, giving those SVN >>> commits on the release branch human-readable change descriptions. >>> >>> Now that our releases are merge commits on branches with full CL >>> descriptions, and moreover the release commits contain a link to a full >>> list of changes, I'm not sure the LOG stuff is buying us anything other >>> than nags from the presubmit script. >>> >>> How would folks feel about dropping it? >>> >>> - Adam >>> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
