Hi Bangfu, This looks like a necessary change, Thanks! Daniel, Ulan, does this look right to you guys? While I have no clue what may be wrong with the depot tools authentication, I cannot confirm that you have signed the CL with your address " [email protected]". Would it be alright with you if we land the change on your behalf and credit you in the commit message once you signed the CLA (again even if you already did)?
Regards, Yang On Thu, Jan 21, 2016 at 10:16 AM <[email protected]> wrote: > Hi, > > I noticed a bug in android-sync.sh, which caused the > android_arm.release.check unittests crash on device. It is fixed by adding: > sync_file "$OUTDIR/$ARCH_MODE/natives_blob.bin" > sync_file "$OUTDIR/$ARCH_MODE/snapshot_blob.bin" > > I would like to upload the changes, but it failed to create CL. Here is > the error message: > v8$> git cl upload > Using 50% similarity for rename/copy detection. Override with --similarity. > You are not logged in. Please login first by running: > depot-tools-auth login https://codereview.chromium.org > > But I did login before trying to upload and I also had CLA two years ago. > > Can anyone please show me what's gone wrong? > > Thanks in advance. > Bangfu > > > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
