https://codereview.chromium.org/1634513002/
git blame tells me the main issue is with symbols and internalized strings, so that's what I moved to src/heap-symbols.h. That's also the set of roots that doesn't require special initialization, so it's really *only* about adding an entry to the macro. -Michael On Thu, Jan 7, 2016 at 4:47 AM Benedikt Meurer <[email protected]> wrote: > Yeah, we talked about that offline before Christmas and mostly agreed that > we should do it soonish. > > Yang Guo <[email protected]> schrieb am Mi., 6. Jan. 2016, 22:02: > >> Ive had thoughts about this as well, and it indeed makes sense. SGTM. >> >> Yang >> >> On Wed, Jan 6, 2016, 20:00 'Adam Klein' via v8-dev < >> [email protected]> wrote: >> >>> Over this break, I've seen a number of changes that have needed >>> heap/OWNERs approval due to the need to add a new Symbol, or a new String, >>> to the top of heap.h. One "solution" to this has been to TBR a heap owner, >>> but I'd really like to see as few TBRs (outside reverts) as possible. >>> >>> What do folks think about moving these macros into something at the top >>> level of src/ instead, and have heap.h include them? >>> >>> - Adam >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
