I cannot build V8 tip any more since the following commit on Feb 26.
commit 567e58390d86c54ebd527d1b95500c415f3caeb5
Author: fmeawad <[email protected]>
Date: Fri Feb 26 09:24:14 2016 -0800
Reland: Add Scoped Context Info (Isolate) to V8 Traces
This patch adds the newly added support for contexts in V8 Tracing, as
well
as use it to mark all the entry points for a V8 Isolate.
Update for reland: The current tracing interface needs to be updated
(AddTraceEvent),
but the embedders need to migrate to the new version before removing
the old version.
(Reland of: https://codereview.chromium.org/1686233002)
The revert happened because the 2 signatures of the old and new
AddTraceEvent where different
so it threw an overload-virtual error on cross arm debug. This issue is
temporary, and to solve
it, I added an implementation of the old and new everywhere until the
embedder implements the new.
BUG=v8:4565
LOG=N
[email protected]
Review URL: https://codereview.chromium.org/1704253002
Cr-Commit-Position: refs/heads/master@{#34332}
../src/api.cc:217:3: error: use of undeclared identifier
'TRACE_EVENT_SCOPED_CONTEXT'
TRACE_EVENT_SCOPED_CONTEXT("v8", "Isolate", isolate);
The change introduced TRACE_EVENT_SCOPED_CONTEXT in src/api.cc but only
defined INTERNAL_TRACE_EVENT_SCOPED_CONTEXT in src/tracing/trace-event.h.
Did I miss anything?
Many thanks,
Deon
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
