MacroAssembler instances are stack allocated. If they're too large (compared to the allowances ensured by the stack check mechanism), allocating one can overflow the stack and crash the process.
On Mon, Apr 11, 2016 at 5:27 PM, <[email protected]> wrote: > What kind of error may this code generate? > > On Monday, April 11, 2016 at 9:04:32 PM UTC+6, Jakob Kummerow wrote: >> >> Define "necessary". It guards against a certain kind of bug (that has >> happened before). >> >> On Mon, Apr 11, 2016 at 11:59 AM, <[email protected]> wrote: >> >>> Hello all. >>> I'm see in code the next static assert: >>> /src/ic/access-compiler.h:82 >>> >>> // Ensure that MacroAssembler has a reasonable size. >>> >>> STATIC_ASSERT(sizeof(MacroAssembler) < 128 * kPointerSize); >>> >>> >>> Is this code necessary? >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
