It breaks cross compile with error:

    GYP_GENERATORS=make \
    tools/gyp/gyp --generator-output="out" gypfiles/all.gyp \
                  -Igypfiles/standalone.gypi --depth=. \
                  -Dv8_target_arch=arm \
                   -Dtarget_arch=arm \
                   \
                  -S.arm.release  -Dcomponent=shared_library 
-Dv8_enable_backtrace=1 -Dwerror='' -Darm_fpu=default 
-Darm_float_abi=default
gyp: Error importing pymod_do_mainmodule (detect_v8_host_arch): No module 
named detect_v8_host_arch
make: *** [out/Makefile.arm.release] Error 1

Fix:

--- a/Makefile
+++ b/Makefile
@@ -448,7 +448,7 @@ $(OUT_MAKEFILES): $(GYPFILES) $(ENVFILE)
        $(eval CXX_TARGET_ARCH:=$(subst aarch64,arm64,$(CXX_TARGET_ARCH)))
        $(eval CXX_TARGET_ARCH:=$(subst x86_64,x64,$(CXX_TARGET_ARCH)))
        $(eval V8_TARGET_ARCH:=$(subst .,,$(suffix $(basename $@))))
-       PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell 
pwd)/build:$(PYTHONPATH):$(shell pwd)/tools/gyp/pylib:$(PYTHONPATH)" \
+       PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell 
pwd)/build:$(shell pwd)/gypfiles:$(PYTHONPATH):$(shell 
pwd)/tools/gyp/pylib:$(PYTHONPATH)
        GYP_GENERATORS=make \
        tools/gyp/gyp --generator-output="$(OUTDIR)" gypfiles/all.gyp \
                      -Igypfiles/standalone.gypi --depth=. \
@@ -459,7 +459,7 @@ $(OUT_MAKEFILES): $(GYPFILES) $(ENVFILE)
                      -S$(suffix $(basename $@))$(suffix $@) $(GYPFLAGS)
 
 $(OUTDIR)/Makefile.native: $(GYPFILES) $(ENVFILE)
-       PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell 
pwd)/build:$(PYTHONPATH):$(shell pwd)/tools/gyp/pylib:$(PYTHONPATH)" \
+       PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell 
pwd)/build:$(shell pwd)/gypfiles:$(PYTHONPATH):$(shell 
pwd)/tools/gyp/pylib:$(PYTHONPATH)
        GYP_GENERATORS=make \
        tools/gyp/gyp --generator-output="$(OUTDIR)" gypfiles/all.gyp \
                      -Igypfiles/standalone.gypi --depth=. -S.native 
$(GYPFLAGS)

(I don't know if path to "build" is still needed, but "gypfiles" is 
definitely missing...)

br,
Marcin

-- 
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to