Will do, on all of these points. On Fri, Feb 19, 2010 at 11:23 AM, <[email protected]> wrote:
> Questions: > > 1. If this is a good idea, why not do it everywhere > (LoadFromGlobalSlotCheckExtensions, EmitNamedPropertyAssignment for > compound > assignments)? > > 2. Would it be easy to port this change to x64? > > > http://codereview.chromium.org/651019/diff/1002/6 > File src/ia32/codegen-ia32.cc (right): > > http://codereview.chromium.org/651019/diff/1002/6#newcode693 > src/ia32/codegen-ia32.cc:693: // Spilling eax makes it free, so > LoadGlobal loads directly into eax. > The comment is still not quite right. LoadIC wants receiver in eax and > the register allocator will prefer eax if free. > > I think it's obvious that Spill(eax) makes it free, but not that the > register allocator prefers it. > > Named stores do use reference in the case of e.x++ and ++e.x, so don't > put that comment at all since it's not true. > > > http://codereview.chromium.org/651019 > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
