This is great, thanks for adding the support Michael! On 5 August 2016 at 14:23, Yang Guo <[email protected]> wrote:
> Thumbs up. This is awesome. > > On Fri, Aug 5, 2016 at 3:10 PM Michael Achenbach <[email protected]> > wrote: > >> Hi! >> >> Did you ever skip a test in a .status file? Did you ever use the hammer >> and skipped it for all testing variants even though it only affected one? >> >> Fear no more! Use variant-aware test expectations >> <https://codereview.chromium.org/2203013002/> now, like: >> >> ['variant == ignition_turbofan', { >> 'failing-test': [FAIL], >> 'flaky-test': [SKIP], >> }] >> >> Please only skip tests for the required variants. If you happen to know >> about existing SKIPs or NO_VARIANT modifiers that should skip less than >> they do, please help cleaning them up. >> >> Cheers >> Michael >> >> P.S. Variant-aware expressions are currently restricted to top-level >> blocks in the status file. >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
