LGTM

http://codereview.chromium.org/647022/diff/9/1005
File test/mjsunit/debug-evaluate.js (right):

http://codereview.chromium.org/647022/diff/9/1005#newcode94
test/mjsunit/debug-evaluate.js:94:
'{"expression":"this.longString","global":true, maxStringLength:-1}',
Please remove the space before maxStringLength for consistency.

http://codereview.chromium.org/647022/diff/9/1005#newcode102
test/mjsunit/debug-evaluate.js:102: longString);
How about adding a test with maxStringLength of 0, 1, and 80 as well?

http://codereview.chromium.org/647022

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to