Actually a potentially easier (and more future proof since BinaryOp ICs will go away when FullCodegen is deprecated) approach would be to turn on the interpreter with the --ignition flag, and instrument the codestubs used by the binary op bytecodes (e.g., CodeStubs::AddWithFeedbackStub).
Cheers Ross On 16 Dec 2016 9:55 am, "Toon Verwaest" <[email protected]> wrote: > You can try to just do it in the binary op ICs in ic.cc, and turn off the > optimizing compilers. That won't catch everything but probably a > significant enough portion to already be worthwhile for what you want. > > One of the main things that this doesn't cover is various special > implementations of builtins that internally use binary ops according to the > spec. > > Good luck :-) > > On Fri, Dec 16, 2016, 07:23 Yang Guo <[email protected]> wrote: > > The implementation of + is spread out in a couple of different places due > to Javascript's semantics, and also due to V8 implementing several > compilers. It's probably easier to instrument your own code with NaN > checks. Maybe there is already a tool out there that does this? > > Cheers, > > Yang > > On Thu, Dec 15, 2016 at 9:49 AM <[email protected]> wrote: > > Maybe ill try to make a step toward. I will check result of "+" operation > for a NaN result. Is "+" implemented in one place or its different source > for each platform? > If all will be fine with "+", only about 10 another operations will left : > ) > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > > -- > > > > * • * > *Yang Guo** • **Google Germany GmbH* > * • *Erika-Mann-Str. 33 > * • *80636 Munich > > • [email protected] > > > Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle > > Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: > Hamburg > > Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, > leiten Sie diese bitte nicht weiter, informieren Sie den Absender und > löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is > confidential. If you are not the right addressee please do not forward it, > please inform the sender, and please erase this e-mail including any > attachments. Thanks. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
