LGTM. Please fix a few nits and I'll land.
Thanks, Vitaly http://codereview.chromium.org/646010/diff/3004/3005 File src/runtime.cc (right): http://codereview.chromium.org/646010/diff/3004/3005#newcode2475 src/runtime.cc:2475: int idx) { Please add asserts about lengths and idx. http://codereview.chromium.org/646010/diff/3004/3005#newcode2476 src/runtime.cc:2476: if (sizeof(pchar) > 1 && sizeof(schar) == 1) { (nit) Swap conditions so that sub checks go before pat checks. http://codereview.chromium.org/646010/diff/3004/3005#newcode4151 src/runtime.cc:4151: CONVERT_DOUBLE_CHECKED(number, args[0]); Let's put this in a separate change. http://codereview.chromium.org/646010 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
