Reviewers: Mads Ager, sgjesse,

Message:
Mads, Søren,

may you have a look?

Checking absence of this element incurs slight perf penalty (~3%), but I think we'd better start with simpler approach and elaborate on it when we have better
infrastructure.

Inlining Heap::AllocateFixedArray apparently brought minimal benefit (I guess
due to small number of reallocations vs. moves thanks to our growth policy).

I've added two mostly identical tests verifying that everything works fine. I
wanted to add __defineGetters__ variants, but getter didn't work for me for
elements.

Is there a way to get rid of duplication for those tests?

Dromaeo runs: http://dromaeo.com/?id=93461,93464

Description:
Faster moving FixedArray elements around.

Please review this at http://codereview.chromium.org/650043

Affected files:
  M src/array.js
  M src/builtins.cc
  M src/objects-inl.h
  M src/objects.h
  M src/runtime.h
  M src/runtime.cc
  A test/mjsunit/array-elements-from-array-prototype.js
  A test/mjsunit/array-elements-from-object-prototype.js
  M test/mjsunit/fuzz-natives.js


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to