No idea how widespread. This was an intentional decision made and explained here <https://bugs.chromium.org/p/chromium/issues/detail?id=692611#c5> (sorry, Googlers only) resulting in requirement of at least tryjob access to operate CQ, even if CL has been approved. It wasn't meant for Gerrit only, but we didn't do this for Rietveld in light of Rietveld's imminent retirement.
We could potentially allow CQ after approval to anyone but only on *exactly* the same patchset that was approved. The workflow for approving new patchsets isn't smooth right now because our Code-Review label is sticky requiring a reviewer to remove and then re-add a CR+1 vote. Thus, I didn't bother doing anything on CQ side. Personally, I think granting try access to responsible contributors is good thing, as it allows them to try their changes before even asking for review. Best regards to v8 contributors, Andrii on behalf of CQ team On Thu, Jul 13, 2017 at 2:06 PM Michael Achenbach <[email protected]> wrote: > CC gerrit-switch experts. I'd like to understand what's the extend of this > problem (e.g. how many people are affected and why) and if we can do > anything to automatically make it work again in Gerrit as it used to in > Rietveld. > > On Thursday, July 13, 2017 at 1:42:45 AM UTC+2, Adam Klein wrote: >> >> Hi Ben, >> >> Indeed this is a change in how Gerrit works compared to Rietveld, and my >> understanding is that all contributors who wish to be able to land their >> own changes need to request V8 tryjob access (CCing machenbach for >> confirmation on that). >> >> I've added you to the proper ACLs, so hitting CQ+2 ("Submit to CQ" >> button) should now work for you on changes that have been lgtm'd by a >> reviewer (as https://chromium-review.googlesource.com/c/566833/ has >> been, by yangguo). >> >> On Wed, Jul 12, 2017 at 6:01 AM, Ben Noordhuis <[email protected]> >> wrote: >> >>> Hi, >>> >>> I'd like to request try job access so that I can land my CLs (again - >>> used to work before the switch.) >>> >>> CLAs are on file for me personally ([email protected]) as well as >>> from my employer, IBM. >>> >>> Should other Node.js contributors request access individually or can >>> we get some blanket stamp of approval? >>> >>> Thanks, >>> >>> Ben >>> >>> PS: I'm working off [0] but I figured [email protected] is >>> probably not the right place for V8-specific questions. >>> >>> [0] >>> https://www.chromium.org/getting-involved/become-a-committer#TOC-Try-job-access >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
