Following on from the thread in blink-dev and chromium-dev[1], I have a preliminary patch that enabled jumbo v8 builds: https://chromium-review.googlesource.com/c/579090/
In my test setup (an aging pc with 4core/8thread cpu, 32G of ram and an SSD, not using ccache or icecc), I am able to build v8 72% faster than a regular non-jumbo build. I think most of this CL is uncontroversial (rename some symbols, redefine commonly used macros and so on), however I would like opinions on the best way to handle anonymous namespaces, which in jumbo builds are not file-local. In this initial patch, the resolution I am using is to redefine an "ANON" macro to a unique name corresponding to the source file, name the formerly anonymous namespace with that macro, and then add some using ANON::foo statements outside the namespace. This requires a #pragma workaround for clang when using -Wheader-hygiene and -Werror. Perhaps it would be better to just change these into regular named namespaces and specify the namespace when using the symbols? Or just drop anonymous namespaces altogether? [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/B69B105btQg/JWCB2WOdBwAJ -Mostyn. -- Mostyn Bramley-Moore Opera TV [email protected] -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
