Reviewers: Mads Ager,
Description:
Fix bugs in partial snapshots so they work on ARM simulator.
TBR=ager
Please review this at http://codereview.chromium.org/650142
SVN Base:
http://v8.googlecode.com/svn/branches/experimental/partial_snapshots/
Affected files:
M src/serialize.h
M src/serialize.cc
M test/cctest/test-assembler-arm.cc
Index: test/cctest/test-assembler-arm.cc
===================================================================
--- test/cctest/test-assembler-arm.cc (revision 3925)
+++ test/cctest/test-assembler-arm.cc (working copy)
@@ -47,9 +47,6 @@
// The test framework does not accept flags on the command line, so we set
them
static void InitializeVM() {
- // disable compilation of natives by specifying an empty natives file
- FLAG_natives_file = "";
-
// enable generation of comments
FLAG_debug_code = true;
Index: src/serialize.h
===================================================================
--- src/serialize.h (revision 3925)
+++ src/serialize.h (working copy)
@@ -369,6 +369,7 @@
class Serializer : public SerializerDeserializer {
public:
explicit Serializer(SnapshotByteSink* sink);
+ ~Serializer();
void VisitPointers(Object** start, Object** end);
// You can call this after serialization to find out how much space was
used
// in each space.
Index: src/serialize.cc
===================================================================
--- src/serialize.cc (revision 3925)
+++ src/serialize.cc (working copy)
@@ -892,7 +892,7 @@
Serializer::Serializer(SnapshotByteSink* sink)
: sink_(sink),
current_root_index_(0),
- external_reference_encoder_(NULL),
+ external_reference_encoder_(new ExternalReferenceEncoder),
large_object_total_(0) {
for (int i = 0; i <= LAST_SPACE; i++) {
fullness_[i] = 0;
@@ -900,28 +900,28 @@
}
+Serializer::~Serializer() {
+ delete external_reference_encoder_;
+}
+
+
void StartupSerializer::SerializeStrongReferences() {
// No active threads.
CHECK_EQ(NULL, ThreadState::FirstInUse());
// No active or weak handles.
CHECK(HandleScopeImplementer::instance()->blocks()->is_empty());
CHECK_EQ(0, GlobalHandles::NumberOfWeakHandles());
- CHECK_EQ(NULL, external_reference_encoder_);
// We don't support serializing installed extensions.
for (RegisteredExtension* ext = RegisteredExtension::first_extension();
ext != NULL;
ext = ext->next()) {
CHECK_NE(v8::INSTALLED, ext->state());
}
- external_reference_encoder_ = new ExternalReferenceEncoder();
Heap::IterateStrongRoots(this, VISIT_ONLY_STRONG);
- delete external_reference_encoder_;
- external_reference_encoder_ = NULL;
}
void PartialSerializer::Serialize(Object** object) {
- external_reference_encoder_ = new ExternalReferenceEncoder();
this->VisitPointer(object);
// After we have done the partial serialization the partial snapshot
cache
@@ -935,9 +935,6 @@
startup_serializer_->VisitPointer(&partial_snapshot_cache_[index]);
}
partial_snapshot_cache_length_ = kPartialSnapshotCacheCapacity;
-
- delete external_reference_encoder_;
- external_reference_encoder_ = NULL;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
