Clemens Hammacher writes: > Please go ahead and open a bug for this. I saw at least one TODO about > profiling support for native wasm code, but having a bug to track progress > seems appropriate.
Whoops, I realized I only have permissions to create bug reports. I cannot open a 'FeatureRequest' and assign components such as 'WebAssembly' and 'Tools'. > We should also find out how to add regression tests for this. Can you provide > insights there? My first guess would be to check that the logger outputs the correct code-creation events for native wasm code. Possibly in the same way that cctest/test-log.cc does. At the moment, we do not have any tests for the internal profiling such as profview or the perf jit support. I would assume having tests for user-facing profiling like the integration with the ChromeDevTools would be of higher priority. But I'm not familiar with how this works at all. > > On Tue, Feb 6, 2018 at 2:23 PM Pierre Langlois > <[email protected]<mailto:[email protected]>> wrote: > Hi all, > > We realized we were lacking support for profiling asm.js and WASM, via > the --prof or --perf-prof flags for instance. A quick look showed we'd > need to register WasmCode objects with the logging infrastructure, > probably in the same way as the new InstructionStream support [0]. > > I was going to open a bug for it but thought I'd first ask you it was > something you were aware of? Or is it too early to look into tooling and > profiling for WASM? > > Thanks, > Pierre > > [0]: https://chromium-review.googlesource.com/c/v8/v8/+/897530 > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
