Hi there, This is probably a very trivial question but I am trying to understand the purpose of:
https://cs.chromium.org/chromium/src/v8/src/api.cc?q=SnapshotCreator&sq=package:chromium&g=0&l=593 SnapshotCreator <https://cs.chromium.org/chromium/src/v8/include/v8.h?l=8488&ct=xref_jump_to_def&gsn=SnapshotCreator>::~SnapshotCreator <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=591&gs=kythe%253A%252F%252Fchromium%253Flang%253Dc%25252B%25252B%253Fpath%253Dsrc%252Fv8%252Fsrc%252Fapi.cc%2523soPvzld%25252BUQWNJunU2H9G8iDKGNBCECVM1zU5PP71hao%25253D&gsn=~SnapshotCreator&ct=xref_usages>() { SnapshotCreatorData* data = SnapshotCreatorData <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=542&ct=xref_jump_to_def&gsn=SnapshotCreatorData>::cast(data_ <https://cs.chromium.org/chromium/src/v8/include/v8.h?l=8587&ct=xref_jump_to_def&gsn=data_>); DCHECK <https://cs.chromium.org/chromium/src/v8/src/base/logging.h?l=63&ct=xref_jump_to_def&gsn=DCHECK>(data <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=592&ct=xref_jump_to_def&gsn=data>->created_); // <--- this check Isolate* isolate = data <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=592&ct=xref_jump_to_def&gsn=data>->isolate_ <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=554&ct=xref_jump_to_def&gsn=isolate_>; isolate->Exit <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=8378&ct=xref_jump_to_def&gsn=Exit>(); isolate->Dispose(); delete data <https://cs.chromium.org/chromium/src/v8/src/api.cc?l=592&ct=xref_jump_to_def&gsn=data>;} >From usage of SnapshotCreator there are cases where we can not create snapshot >so created_ is going to be false. This is causing my library to fail when >compiled with debug enabled. Was wondering, why is that check there? If we fail to create a shapshot should I just go ahead and create a blank one anyway? Or perhaps only use a snapshot creator if I know I have good script? -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
