In short: create a Chromium checkout, create a patch, get it reviewed and landed. Details: https://www.chromium.org/developers/contributing-code
Please be aware that there is a chance of pushback -- depending on what you're changing and how, people might not like it. I can't estimate how likely that is in this case. On Fri, Sep 21, 2018 at 2:56 PM <[email protected]> wrote: > Thanks. It is much more clear now. > > The port work would need changes in both build.git and some V8 source > files. What's the suggested way to upstream these related changes? > > On Friday, September 21, 2018 at 11:22:18 AM UTC-7, Jakob Kummerow wrote: >> >> The "build/" directory in a V8 checkout is a checkout of >> https://chromium.googlesource.com/chromium/src/build.git (which in turn >> is a standalone copy of the respective directory in the main Chromium >> repo), see the DEPS file. So yeah, you can't just update that in V8; and >> for porting V8 to another platform it's probably not even the right place >> to make modifications (although depending on what it is that you have to >> modify, it might make sense or possibly even be required to upstream those >> changes). >> >> On Fri, Sep 21, 2018 at 11:11 AM <[email protected]> wrote: >> >>> Thanks. As V8 repo also has its own build scripts under V8\build, is >>> this folder just a mirror of the same folder from Chromium? Could new >>> change goes to V8\build folder, or should go to chromium then update to V8? >>> >>> On Thursday, September 20, 2018 at 5:25:27 PM UTC-7, Jakob Kummerow >>> wrote: >>>> >>>> On Thu, Sep 20, 2018 at 5:14 PM <[email protected]> wrote: >>>> >>>>> For build script, I meant something like >>>>> "chromium\src\build\vs_toolchain.py". >>>>> >>>> >>>> Well, that's in Chromium, not in V8. Also, IIUC that script isn't >>>> involved in building, only in downloading/updating the toolchain. >>>> >>>> >>>>> I'd like to make some change to make V8 build and work Windows 10 on >>>>> ARM which involves build script change. I am wondering if this change goes >>>>> to V8, Chromium will get the same build script change? >>>>> >>>> >>>> As I said: generally yes. Chromium pulls in V8 as a dependency. >>>> >>>> >>>>> >>>>> On Wednesday, September 19, 2018 at 5:52:08 PM UTC-7, Jakob Kummerow >>>>> wrote: >>>>>> >>>>>> Generally yes, but can you be a little more specific regarding which >>>>>> "build script" you're talking about? >>>>>> >>>>>> On Wed, Sep 19, 2018 at 5:33 PM <[email protected]> wrote: >>>>>> >>>>>>> If some V8 contribution involves changing build script (python >>>>>>> source), does the contribution affect Chromium build immediately after >>>>>>> it >>>>>>> is merged? >>>>>>> >>>>>>> -- >>>>>>> -- >>>>>>> v8-dev mailing list >>>>>>> [email protected] >>>>>>> http://groups.google.com/group/v8-dev >>>>>>> --- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "v8-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>> -- >>>>> -- >>>>> v8-dev mailing list >>>>> [email protected] >>>>> http://groups.google.com/group/v8-dev >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "v8-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
