I think the question is whether we need to have both budget-driven interrupts and stack checks. IIRC what we did in FullCodegen was dropping the latter and relying exclusively on the former. A GC or termination request would just have to wait until the next budget-triggered interrupt.
That said, I agree that this is only worth mucking with if we have evidence that it impacts performance. On Wed, Oct 24, 2018 at 1:53 AM 'Ross McIlroy' via v8-dev < [email protected]> wrote: > We use the stack-check for various operations, like installing optimized > code, running GC or terminating execution. If we skip it during loop bodies > then these operations would be delayed by long-running loops, and, for > example, we couldn't terminate execution of infinite loops, and we wouldn't > install optimized code during these loops (which I believe would prevent > on-stack-replacement and so would regress performance for certain code). > > I'm guessing you want to do this for performance reasons? Do you have any > evidence that the stack-check has any significant performance impact on > real-world benchmarks? > > Cheers, > Ross > > > On Fri, 19 Oct 2018 at 11:38, <[email protected]> wrote: > >> Hi, The stack-check was skipped in old v8 full-codegen loop body, just >> wondering if it is safe to do so for new v8 interpreter? Thanks. >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
