On Mon, Oct 22, 2018 at 12:41 PM Leszek Swirski <[email protected]> wrote:
> We don't check this on dry-run, afaik, so that dry runs don't fail during > the review process (and reviewers can easily see if tests pass). > This is what I remembered as well. What confused me is that it seemed like CQ dry run has triggered the v8_presubmit build <https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_presubmit/b8934277449434388688>. In fact CQ dry run has not triggered anything since the Isiah is neither a committer nor has tryjob access: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1246801/4. According to the underlying swarming task <https://chromium-swarm.appspot.com/task?id=40311ff0805b2b10&refresh=10&show_raw=1&wide_logs=true>, it was manually triggered by [email protected], who is a committer, via "Choose tryjobs" feature on Gerrit. I am not sure which logic presubmit users for such builds. Either way, the main blocker here is that Isiah needs to change his email address on Gerrit in a way that presubmit would recognize. Since email is not a great way to track this and Gerrit admins may not be monitoring this list, I've filed a bug on Isiah's behalf: https://crbug.com/899728. > > On Mon, Oct 22, 2018 at 11:39 AM Sergiy Byelozyorov <[email protected]> > wrote: > >> The presubmit has also failed since an owner of the V8 root directory >> needs to LGTM your CL. OTH, I am surprised that we do this check on dry-run. >> >> With regards to being in the AUTHORS file, adding an alternative email >> may not be sufficient since I can see that the presubmit code simply checks >> author_email field >> <https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py?l=92&rcl=98f1e59b41c6c580cd168ac4456bf27d78c12a95>, >> which is probably the default email address. [email protected] >> <[email protected]>, can you please advice if Isiah needs to >> register a new account on Gerrit or if their existing account can be >> updated somehow to use the new address as a primary one? >> >> On Sun, Oct 21, 2018 at 3:27 PM 'Mathias Bynens' via v8-dev < >> [email protected]> wrote: >> >>> [image: image.png] >>> >>> On Sat, Oct 20, 2018 at 9:45 PM Isiah Meadows <[email protected]> >>> wrote: >>> >>>> It *should* be the same account. I added it as an alternate email. >>>> >>>> On Saturday, October 20, 2018 at 1:09:57 AM UTC-4, Jakob Kummerow wrote: >>>>> >>>>> As you can see on the CL, it fails the presubmit check, because it is >>>>> has been created by an account that's not listed in the AUTHORS file, so >>>>> it >>>>> can't be landed. You'll have to re-upload it from the account that you're >>>>> adding to the AUTHORS file. >>>>> >>>>> On Fri, Oct 19, 2018 at 7:50 PM Isiah Meadows <[email protected]> >>>>> wrote: >>>>> >>>>>> I made a quick, small CL about a month ago to change my email listed >>>>>> in the AUTHORS file, and nobody has looked at it yet. Did I miss >>>>>> something, >>>>>> or was it just forgotten? >>>>>> >>>>>> https://chromium-review.googlesource.com/c/v8/v8/+/1246801 >>>>>> >>>>>> -- >>>>>> -- >>>>>> v8-dev mailing list >>>>>> [email protected] >>>>>> http://groups.google.com/group/v8-dev >>>>>> --- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "v8-dev" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> -- >>>> -- >>>> v8-dev mailing list >>>> [email protected] >>>> http://groups.google.com/group/v8-dev >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> Sergiy Byelozyorov | Software Engineer | [email protected] >> >> Google Germany GmbH >> Erika-Mann-Strasse 33 >> <https://maps.google.com/?q=Erika-Mann-Strasse+33+80636+M%C3%BCnchen&entry=gmail&source=g> >> 80636 München >> <https://maps.google.com/?q=Erika-Mann-Strasse+33+80636+M%C3%BCnchen&entry=gmail&source=g> >> >> AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer: >> Paul Manicle, Halimah DeLaine Prado >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "infra-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAGRskv_igSOnW9_YxfAxeruF%3DWK5ZvRS0fXtiwwP5XkOrivtnw%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAGRskv_igSOnW9_YxfAxeruF%3DWK5ZvRS0fXtiwwP5XkOrivtnw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Sergiy Byelozyorov | Software Engineer | [email protected] Google Germany GmbH Erika-Mann-Strasse 33 80636 München AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer: Paul Manicle, Halimah DeLaine Prado -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
