That's a reasonable point, but SFI::HasSharedName also checks for the kNoSharedNameSentinel, which ScopeInfo::HasFunctionName does not. There is a ScopeInfo::HasSharedFunctionName, but that one in turn does not first check for ScopeInfo::HasFunctionName(). Possibly we could add ScopeInfo::HasFunctionName() to ScopeInfo::HasSharedFunctionName and then remove this check.
Is there any reason you are looking at this code in particular? On Sun, Nov 25, 2018 at 3:06 AM 박한범 <[email protected]> wrote: > You can find the code here: > > > https://chromium.googlesource.com/v8/v8.git/+/master/src/objects/shared-function-info-inl.h > line 102 > line 110 > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
