On 2010/02/24 08:23:31, Søren Gjesse wrote:
On 2010/02/23 16:05:13, Evan Martin wrote:
> Did this ever land? I saw a v8 merge happen and I eagerly checked for this
line
> but I didn't see it...

I am sorry it did not. I am still a bit uneasy about the difference in flags between the V8 SCons build and the build files generated from v8.gyp. But as most of them are only related to relaxing warning/error levens and disabling
some optimizations I will go ahead and commit it.

I expect that the v8 scons file and v8 gyp file generate different flags -- what is probably better to check is whether v8 gyp file generates different settings
with chromium_code=1 vs chromium_code=0.

http://codereview.chromium.org/570022

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to