LGTM Note that although the Test262 tests for this feature <https://github.com/tc39/test262/pull/1983> haven’t been merged yet, we’ve converted them all to cctest/mjsunit tests, which are all passing. Since the feature is relatively small/contained, I’m okay with *not* waiting on the Test262 issues to be resolved in this particular case.
On Mon, Jan 28, 2019 at 8:58 AM Caitlin Potter <[email protected]> wrote: > *Contact emails:* > [email protected], [email protected] > > *Spec*: https://tc39.github.io/proposal-hashbang/ > *V8-Bug: *https://crbug.com/v8/8523 > > *Explainer / Summary / Motivation:* > This proposal is to match de-facto usage in some CLI JS hosts that allow > for Shebangs / Hashbang. Such hosts strip the hashbang in order to generate > valid JS source texts before passing to JS engines currently. This would > unify and standardize how that is done. > > This feature is generally not intended to be consumed by the browser > (rather, non-browser JS hosts) --- however, it potentially allows for a > script with an interpreter line to run in the browser without modification, > which could be seen as a benefit. > > *Interoperability and Compatibility* *Risks**:* > Firefox: In development ( > https://bugzilla.mozilla.org/show_bug.cgi?id=1519097) > Safari: Unknown > > *Ergonomics:* > N/A, with the exception that we will want to make sure the web inspector > knows how to process the interpreter line, so that it doesn't harm the > debugging experience. > *Activation:* n/a > > *Link to entry on the feature dashboard:* > https://www.chromestatus.com/feature/5134505706782720 > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8ABC1C20-B816-4945-B9B3-6630CDE6967B%40chromium.org > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/8ABC1C20-B816-4945-B9B3-6630CDE6967B%40chromium.org?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
