On Wed, May 22, 2019 at 10:22 AM Dominik Gruber < [email protected]> wrote:
> can you give me an example on how to run a test procedure from > "test-api-stack-traces.cc"? Running "tools/run-tests.py > --outdir=out/x64.release cctest" does not result in any test runs. > That should work, as in: it works for me. Make sure you have compiled cctests first, either with ninja -C out/x64.release cctest or with tools/dev/gm.py x64.release cctest. You can also save some time by only running the tests you care about: tools/run-tests.py --outdir=out/x64.release cctest/test-api-stack-traces/*. With gm.py, you can even conveniently build and run with a single command: tools/dev/gm.py x64.release cctest/test-api-stack-traces takes care of everything. > I guess I have to define a target, but I am struggling to find the correct > parameters. > > Thanks, > Dominik > > On Monday, May 20, 2019 at 1:40:40 PM UTC+2, Simon Zünd wrote: >> >> Unfortunately we don't accept patches from Github PRs and we don't review >> code on Github. Please follow the instructions at >> https://chromium.googlesource.com/chromium/src/+/master/docs/contributing.md#Uploading-a-change-for-review. >> This way, the CL can run against our Try bots and the CL can properly be >> reviewed in Gerrit. >> >> On Mon, May 20, 2019 at 1:25 PM Dominik Gruber <[email protected]> >> wrote: >> >>> Hi Simon, >>> >>> Dynatrace has already signed the CLA. >>> I am currently porting the changeset to our v8 fork. Is it sufficient if >>> I provide the link to the git repo with the changelist for reviewing? >>> >>> Thanks, >>> Dominik >>> >>> >>> On Thursday, May 16, 2019 at 2:10:09 PM UTC+2, Simon Zünd wrote: >>>> >>>> Hi Dominik, >>>> >>>> for general V8 contribution guidelines, please follow >>>> https://v8.dev/docs/contribute. There is also currently some work >>>> going regarding stack traces. Feel free to use the same tracking bug ( >>>> https://crbug.com/v8/8742) for your CLs. You can send your CLs to me >>>> for review and I will add additional reviewers as necessary. >>>> >>>> AFAIK Node 12 will stay at V8 API compatibility of 7.5 (the current V8 >>>> version being worked on is 7.6). Meaning your change won't make it into >>>> Node 12. Note that the contribution process for Node itself differs from >>>> V8. >>>> >>>> Cheers, >>>> Simon >>>> >>>> *From: *Jakob Gruber <[email protected]> >>>> *Date: *Thu, May 16, 2019 at 2:01 PM >>>> *To: * <[email protected]>, Simon Zünd, Yang Guo >>>> >>>> +Simon Zünd +Yang Guo >>>>> >>>>> *From: *Dominik Gruber <[email protected]> >>>>> *Date: *Thu, May 16, 2019 at 1:58 PM >>>>> *To: *v8-dev >>>>> >>>>> Dear v8 community, >>>>>> >>>>>> Background: The native API is lacking the functionality "GetTypeName" >>>>>> on StackFrame objects contrary to Callsites where this feature is >>>>>> available >>>>>> to the managed API. >>>>>> >>>>>> We have implemented and tested this feature with Nodejs and would >>>>>> like to contribute those changes to the v8 source and get that feature >>>>>> into >>>>>> Nodejs as soon as possible. >>>>>> >>>>>> Can someone guide me through the contribution process regarding issue >>>>>> creation, code review, merge to Nodejs? >>>>>> >>>>>> Thanks, >>>>>> Dominik >>>>>> >>>>>> -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3SuMmM7FTRyUEaoT8YBU2xYOEWEt%2BBEoAOEzp%2BYVtBTVw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
