That's a great investigation, thanks! We can't really fix the benchmark, changing benchmarks invalidates historical data and confuses cross browser comparisons, so we've had to live with more than a few benchmark bugs.
However, the closed-over constructor observation is particularly interesting to me - it's hard to tell if this is a typical construct outside of benchmarks, but if it is then it suggests that we shouldn't be sharing feedback between closures of a constructor function. Call-site specific feedback would be another option that we've discussed in the past (for other reasons, e.g. calling dispatch functions). Good stuff. On Wed, 17 Jul 2019, 02:24 surshar via v8-dev, <[email protected]> wrote: > Hello everyone, > > I have been investigating v8's performance on JetStream 2 > <http://localhost/perf/JetStream2/in-depth.html> and found one > interesting test(3d-cube SP > <http://localhost/perf/JetStream2/SunSpider/3d-cube.js>) where we can > achieve a significant performance gain. > > Here's the link > <https://docs.google.com/document/d/1UzCOai9H07fYcSaSqvF_H7BS2-sF5q91A4r9O1mRnHc/edit?usp=sharing>to > the doc summarizing my findings. > > Please take a look > > Thanks! > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/b090d8be-4423-4655-8f5d-3035bc73090d%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/b090d8be-4423-4655-8f5d-3035bc73090d%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGRskv_JEbkOiFT0Eo8u8sbRW8DG-EyR-S%2Bafm%2BuNanPix7yBw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
