LGTM with comments addressed.
http://codereview.chromium.org/661075/diff/1/6 File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/661075/diff/1/6#newcode51 src/arm/assembler-arm.cc:51: #ifdef __arm__ Please add comment // NAME_OF_DEFINE to all #else's and #endif's http://codereview.chromium.org/661075/diff/1/6#newcode72 src/arm/assembler-arm.cc:72: #if !defined(__arm__) #ifndef for consistency? Maybe turn it around to be an #ifdef. http://codereview.chromium.org/661075/diff/1/3 File src/platform-freebsd.cc (right): http://codereview.chromium.org/661075/diff/1/3#newcode194 src/platform-freebsd.cc:194: void OS::DebugBreak() { Wont this not lead to emitting int $3 with __arm__ defined and CAN_USE_ARMV5_INSTRUCTIONS not defined? In platform-linux.cc and platform-openbsd.cc as well. http://codereview.chromium.org/661075 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
