LGTM.
http://codereview.chromium.org/608031/diff/6009/6010 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/608031/diff/6009/6010#newcode6751 src/ia32/codegen-ia32.cc:6751: __ mov(scratch_, receiver_); // Safe even if key_ is also in scratch_. I'm not sure if I understand this comment: Isn't this path unfeasible if key_ is already in scratch_? http://codereview.chromium.org/608031/diff/6009/6014 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/608031/diff/6009/6014#newcode708 src/ia32/ic-ia32.cc:708: // Add 1 to reciever->length, and go to fast array write. Typo --> receiver http://codereview.chromium.org/608031/diff/6009/6014#newcode817 src/ia32/ic-ia32.cc:817: __ fstp_s(Operand(edi, ebx, times_4, 0)); Tiny optimization: To remove the pop-instruction instead of __ push(ecx) __ fild_s(...) __ pop(ecx) __ fstp_s(...) __ ret(0) you could just do __ push(ecx) __ fild_s(...) __ fstp_s(...) __ ret(4) And hoist __ ret(0) into the switch-statement for the other cases. http://codereview.chromium.org/608031 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
