Thanks! Submitted. BTW, uintptr_t turned out to be faster for large strings on x64.
-- Vitaly http://codereview.chromium.org/650058/diff/1/3 File src/runtime.cc (right): http://codereview.chromium.org/650058/diff/1/3#newcode4639 src/runtime.cc:4639: if (x->IsFlat() && y->IsFlat()) { On 2010/02/22 10:14:00, Søren Gjesse wrote:
How about moving the body of this if into a function, e.g.
FlatStringCompare?
And make it into an if/else.
Done. http://codereview.chromium.org/650058/diff/1/3#newcode4665 src/runtime.cc:4665: r = CompareChars(x_chars.start(), y_chars.start(), prefix_length); On 2010/02/22 10:14:00, Søren Gjesse wrote:
There is a wmemcmp in wchar.h - don't know if it makes sense to use it
here. I'm worried about variations in wchar_t definitions. http://codereview.chromium.org/650058 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
