LGTM
http://codereview.chromium.org/652119/diff/2001/3002 File src/objects.cc (right): http://codereview.chromium.org/652119/diff/2001/3002#newcode3078 src/objects.cc:3078: if (code->type() == NORMAL) { It is not completely trivial that MONOMORPHIC & NORMAL implies that the code is for accessing a global property. Could you add a comment just stating that this is the case. It is clear however, that MONOMORPHIC & NORMAL means that there can be an unbounded number of them and we therefore need a hash table. http://codereview.chromium.org/652119/diff/2001/3002#newcode3079 src/objects.cc:3079: // Make sure the a hash table is allocated got the global access code cache. the -> that got -> for? http://codereview.chromium.org/652119/diff/2001/3002#newcode3202 src/objects.cc:3202: // This is not used for global object IC's. Should we just assert that code->type() != NORMAL in that case? http://codereview.chromium.org/652119/diff/2001/3002#newcode3228 src/objects.cc:3228: // code object. The actual match is on the name and the code flags. If this key this -> a http://codereview.chromium.org/652119/diff/2001/3002#newcode3229 src/objects.cc:3229: // is created using the flags in not a code object it can only be used for in -> and http://codereview.chromium.org/652119/diff/2001/3003 File src/objects.h (right): http://codereview.chromium.org/652119/diff/2001/3003#newcode3733 src/objects.h:3733: // Lookup Code object in the cache. Returns code object if found. Code -> code. Document what it returns when not found? http://codereview.chromium.org/652119/diff/2001/3003#newcode3737 src/objects.h:3737: // code object is not in that cache. This index can be ised to later call ised -> used http://codereview.chromium.org/652119/diff/2001/3003#newcode3763 src/objects.h:3763: // Code cache layout. The code cache is a fixed array where the first element This comment looks wrong - left over from a previous version of this change? http://codereview.chromium.org/652119 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
