If you see such issues frequently, I think you can file an issue to set up the bot to detect that. But I currently think fixing after CQ failure in your repository seems reasonable.
+Nico Weber <tha...@chromium.org> Do you have any thoughts for this? On Fri, Apr 24, 2020 at 6:30 AM K. Moon <km...@chromium.org> wrote: > Hi infra folks, > > Chromium doesn't support MSVC anymore, but PDFium and V8 explicitly do, > and take some dependencies from Chromium, like //third_party/zlib. > > I recently ran into an issue with MSVC compilation while rolling DEPS for > PDFium (see crrev.com/c/2161475 for more details). The breaking change to > //third_party/zlib wasn't caught by the MSVC bots. (Some speculation as to > why on https://pdfium-review.googlesource.com/c/pdfium/+/69002.) This > required a fix to third_party/zlib/BUILD.gn before the PDFium roll > succeeded. V8 likely would have had the same issue when trying to roll zlib. > > As long as PDFium and V8 continue to maintain MSVC support, I was > wondering if there's some way we could make sure the Chromium bots catch > such things? Right now, they don't seem to catch changes to zlib. > > --Kahmy > > -- > You received this message because you are subscribed to the Google Groups > "infra-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to infra-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACwGi-5gsTqbHB4WnPHWHTb_7LKkemwwfzBXe5KUFvG95GRkiA%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACwGi-5gsTqbHB4WnPHWHTb_7LKkemwwfzBXe5KUFvG95GRkiA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CALNjmMrLmMoegQRuzm4Gp92T8Vp8zrpcM7YSuC9_eQpZthJ_yg%40mail.gmail.com.
