LGTM
You could look at the code generated for the loop on ARM - it probably
cannot be
improved.
Are there other placed we can use this. I am thinking filling hash tables
with
undefined.
http://codereview.chromium.org/661105/diff/1/2
File src/heap.cc (right):
http://codereview.chromium.org/661105/diff/1/2#newcode2981
src/heap.cc:2981: // update RSets.
Please keep the assert.
http://codereview.chromium.org/661105/diff/1/3
File src/utils.h (right):
http://codereview.chromium.org/661105/diff/1/3#newcode584
src/utils.h:584: asm("cld\n\trep\n\t" STOS
Please break this into one instruction per line for better redability.
http://codereview.chromium.org/661105/diff/1/3#newcode587
src/utils.h:587: :);
Maybe make a comment why the clobber list is empty.
http://codereview.chromium.org/661105/diff/1/3#newcode594
src/utils.h:594: #undef HAS_STOS
HAS_STOS -> STOS
http://codereview.chromium.org/661105
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
