On Thu, Sep 24, 2020 at 8:48 AM Benedikt Meurer <[email protected]> wrote:
> Ups, I mixed the numbers. I was proposing to stick to Solution #2, for the > reason that this requires fewer (risky) changes to TurboFan. Reading the > doc again, you might over time migrate closer to Solution #1 if you want, > since a lot of the places in TurboFan don't really require the extra > FrameState, it's just that this was the way the world worked back when we > wrote most of this code. > Thanks, I also think this might be a good way to go, I've actually discussed a similar idea with Toon yesterday. :) > > cheers, > Benedikt > > On Tue, Sep 22, 2020 at 10:30 AM 'Victor Gomes' via v8-dev < > [email protected]> wrote: > >> Thanks Benedikt! >> >> On Mon, Sep 21, 2020 at 6:04 PM Benedikt Meurer <[email protected]> >> wrote: >> >>> *"Lasciate ogne speranza, voi ch'intrate"* (aka *"Abandon all hope, >>> ye who enter here..."*) >>> >> Queste parole di colore oscuro vid’ ïo scritte al sommo d’una porta; per >> ch’io: «Maestro, il senso lor m’è duro». " (These words—their aspect was >> obscure—I read inscribed above a gateway, and I said: “Master, their >> meaning is difficult for me.”) >> >> But more seriously... this is definitely tricky territory, and my >>> recommendation would be Solution #1 in your document. >>> >> Why do you think solution #1 is better? Should we attach the information >> to the caller or to the calee? >> >> >>> >>> On Mon, Sep 21, 2020 at 10:48 AM 'Victor Gomes' via v8-dev < >>> [email protected]> wrote: >>> >>>> Hi V8 masters, >>>> >>>> As part of my work in removing the arguments adaptor frame, I am >>>> turning my attention to the deoptimizer. Since I found it a bit tricky to >>>> understand what's going on, I've written a small doc. >>>> >>>> PTAL: >>>> >>>> https://docs.google.com/document/d/150wGaUREaZI6YWqOQFD5l2mWQXaPbbZjcAIJLOFrzMs/edit?usp=sharing >>>> >>>> Thanks, >>>> -- Victor >>>> >>>> -- >>>> -- >>>> v8-dev mailing list >>>> [email protected] >>>> http://groups.google.com/group/v8-dev >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/v8-dev/CAGFuzY0LLM7%2BAjoaax1usWN9Jov1eq89EvdYKdVDtdR80j5rFA%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/v8-dev/CAGFuzY0LLM7%2BAjoaax1usWN9Jov1eq89EvdYKdVDtdR80j5rFA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> >>> >>> -- >>> >>> Benedikt Meurer >>> >>> Chromium DevTools TL >>> >>> [email protected] >>> >>> Google Germany GmbH >>> >>> Erika-Mann-Straße 33 >>> >>> 80636 München >>> >>> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado >>> >>> Registergericht und -nummer: Hamburg, HRB 86891 >>> >>> Sitz der Gesellschaft: Hamburg >>> >>> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten >>> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, >>> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, >>> dass die E-Mail an die falsche Person gesendet wurde. >>> >>> >>> >>> This e-mail is confidential. If you received this communication by >>> mistake, please don't forward it to anyone else, please erase all copies >>> and attachments, and please let me know that it has gone to the wrong >>> person. >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/CAGowDnbtqL%3DKaJPwwrtWMGQgeFf9rwizRLwMW16M93MWGcfv1w%40mail.gmail.com >>> <https://groups.google.com/d/msgid/v8-dev/CAGowDnbtqL%3DKaJPwwrtWMGQgeFf9rwizRLwMW16M93MWGcfv1w%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> Victor Gomes >> >> Software Engineer >> >> [email protected] >> >> Google Germany GmbH >> >> Erika-Mann-Straße 33 >> >> 80636 München >> >> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado >> >> Registergericht und -nummer: Hamburg, HRB 86891 >> >> Sitz der Gesellschaft: Hamburg >> >> Diese E-Mail ist vertraulich. Falls Ssie diese fälschlicherweise erhalten >> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, >> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, >> dass die E-Mail an die falsche Person gesendet wurde. >> >> >> >> This e-mail is confidential. If you received this communication by >> mistake, please don't forward it to anyone else, please erase all copies >> and attachments, and please let me know that it has gone to the wrong >> person. >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-dev/CAGFuzY14UiG8rwbaB7xF4beF_L5NRv4DW8Vj%3DCrhXNsuvJ2nmQ%40mail.gmail.com >> <https://groups.google.com/d/msgid/v8-dev/CAGFuzY14UiG8rwbaB7xF4beF_L5NRv4DW8Vj%3DCrhXNsuvJ2nmQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > > Benedikt Meurer > > Chromium DevTools TL > > [email protected] > > Google Germany GmbH > > Erika-Mann-Straße 33 > > 80636 München > > Geschäftsführer: Paul Manicle, Halimah DeLaine Prado > > Registergericht und -nummer: Hamburg, HRB 86891 > > Sitz der Gesellschaft: Hamburg > > Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten > haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, > löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, > dass die E-Mail an die falsche Person gesendet wurde. > > > > This e-mail is confidential. If you received this communication by > mistake, please don't forward it to anyone else, please erase all copies > and attachments, and please let me know that it has gone to the wrong > person. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/CAGowDnb_O_uzY9nKnLQ__K8GdYFLfCiXvB0zHUAvHSMiciUPJg%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-dev/CAGowDnb_O_uzY9nKnLQ__K8GdYFLfCiXvB0zHUAvHSMiciUPJg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > Victor Gomes Software Engineer [email protected] Google Germany GmbH Erika-Mann-Straße 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Ssie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGFuzY1QAZvFK1SQ5L%3D8SKmjZybExHKm45M2mSNVjjQPA1A6Ow%40mail.gmail.com.
